Copying MCAD CRDs in Kustomize config instead of referencing them #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
astefanutti
reviewed
Oct 19, 2023
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
ced548c to
026ab8e
Compare
astefanutti
reviewed
Oct 19, 2023
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
026ab8e to
07f6abf
Compare
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
5a20ccb to
b2966ee
Compare
astefanutti
reviewed
Oct 20, 2023
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
24e8620 to
5703472
Compare
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
5703472 to
72524ca
Compare
Fiona-Waters
force-pushed
the
mcad-crds
branch
3 times, most recently
from
138c2eb to
5eb6db6
Compare
dimakis
reviewed
Oct 20, 2023
Makefile
Outdated
| .PHONY: check_yq | ||
| check_yq: | ||
| @command -v yq >/dev/null 2>&1 || (echo "Installing wget..."; yum install -y wget) | ||
| @command -v yq >/dev/null 2>&1 || (echo "Installing yq..."; wget https://github.com/mikefarah/yq/releases/download/v4.2.0/yq_linux_amd64.tar.gz -O - |\ |
dimakis
reviewed
Oct 20, 2023
Makefile
Outdated
|
|
||
| .PHONY: check_yq | ||
| check_yq: | ||
| @command -v yq >/dev/null 2>&1 || (echo "Installing wget..."; yum install -y wget) |
There was a problem hiding this comment.
this should be
@command -v wget
Fiona-Waters
force-pushed
the
mcad-crds
branch
from
5eb6db6 to
e1f3759
Compare
dimakis
reviewed
Oct 20, 2023
Makefile
Outdated
| process_sections: | ||
| @mkdir -p $(output_dir) | ||
| @for section_file in $(temp_dir)/section_*; do \ | ||
| metadata_name=$$(yq e '.metadata.name' $$section_file); \ |
|
If you check out this: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md On ubuntu latest wget is preinstalled, and yum is not :) |
dimakis
reviewed
Oct 20, 2023
Makefile
Outdated
| $(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./..." | ||
| $(SED) -i -E "s|(- )\${MCAD_REPO}.*|\1\${MCAD_CRD}|" config/crd/mcad/kustomization.yaml | ||
| $(KUSTOMIZE) build config/crd/mcad > config/crd/mcad.yaml && make split_yaml FILE=config/crd/mcad.yaml |
dimakis
reviewed
Oct 20, 2023
Makefile
Outdated
| $(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./..." | ||
| $(SED) -i -E "s|(- )\${MCAD_REPO}.*|\1\${MCAD_CRD}|" config/crd/mcad/kustomization.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #353
What changes have been made
Refactored to copy MCAD CRDs instead of referencing them.
Verification steps
make manifestsand ensure that the config/crd/mcad/kustomization.yaml shows the mcad version (not 0.0.0.0).make installand ensure that the required CRDs have been created and that everything runs as expected.Checks